Refactor: remove a useless loop #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
thibault
commented
Jan 9, 2026
|
|
||
| <a class="fr-btn fr-icon-arrow-right-line fr-btn--icon-right" | ||
| href="{% url 'petition_project_instructor_dossier_complet_view' petition_project.reference %}">Voir le dossier complet</a> | ||
| <section class="fr-my-3w" id="moulinette-regulation-result"> |
Collaborator
Author
There was a problem hiding this comment.
J'ai simplement supprimé les deux lignes {% for … %} {% if regulation.slug… %}. Le reste du diff est simplement la mise à jour de l'identation du template.
numahell
approved these changes
Jan 12, 2026
numahell
reviewed
Jan 12, 2026
Collaborator
numahell
left a comment
numahell
left a comment
There was a problem hiding this comment.
T'as dû le voir, il y a un test e2e qui plante sur la régulation espèces protégées.
thibault
force-pushed
the
refactor_get_regulation
branch
from
841a889 to
1a155a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il y avait une boucle inutile dans le template, dont le seul but était de sélectionner une des réglementations de la liste.